[iOS] Fix NRE in Shell SearchHandlerAppearanceTracker #24970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@jfversluis Sorry to be annoying. Can we retry the failed checks or even better just wave this PR through =) I dare say the change wont break anything. |
|
A community PR is never annoying!
Famous last words... |
jfversluis
approved these changes
Oct 2, 2024
|
Thank you so much for your contribution! And for Hacktoberfest too! Go update your LinkedIn and social media profiles! |
samhouts
added
fixed-in-net8.0-nightly
rmarinho
pushed a commit
that referenced
this pull request
Oct 16, 2024
rmarinho
pushed a commit
that referenced
this pull request
Oct 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix crash on iOS involving Shell SearchHandler.
Fallback to
_defaultPlaceholderTintColoriftargetColoris null inUpdateClearPlaceholderIconColor.Issues Fixed
Fixes #19504
A previous PR fixed an identical problem #11927
Steps to Reproduce
Create a shell with two shell content. Add a SearchHandler to one ShellContent ContentPage.
Start application. Click on the SearchHandler. Navigate to the other page. Navigate back. NullReferenceException crash.